cure(daisy): 42 autonomous tidies, skim+companion-gated — for review #52

Merged

calliope merged 43 commits from erato/cure-daisy into erato/focus 2026-06-23 13:31:52 +00:00 AGit

Conversation 1 Commits 43 Files changed 1 +42 -6

erato commented 2026-06-22 23:35:31 +00:00

Collaborator

Copy link

No description provided.

erato added 42 commits 2026-06-22 23:35:31 +00:00

tidy(lib): declare new_source variable for clarity ccfcbff04f

tidy(lib): localize function_def variable in pick function 9e31ea1064

refactor(lib): make source_content local to function 223f3889ae

refactor(lib): make existing_tests local to avoid name collisions 8224099a93

tidy(news): localize variable to function scope a78d55745b

tidy(lib): make prompt local to graft function 258e4cd867

tidy(daisy): make move variable local to graft function 2bda1aa7a7

tidy(daisy): localize verdict variable to function scope 37ae42af3c

tidy(daisy): make baseline_green local for scope isolation 38702fadaf

refactor(daisy): limit variable scope in grow function 7de2edb740

tidy(lib): make code variable local to prevent namespace pollution c7a9538a42

refactor(daisy): make plan local in grow function 87eb57cb14

refactor(daisy): make plan variable local in grow function a9cf2e60fe

tidy(daisy): Make verdict local to loop to avoid variable leakage d047481a52

tidy(lib): declare n_total as local to prevent name clashes 0e054c7abb

tidy(daisy): make n_green local in loop function 97e1204a3d

tidy(lib): make baseline_green local in loop function 8fd0a61f1f

tidy(lib): localize tests variable declaration 1fca1ee2c4

tidy(lib-daisy): make code variable local within loop function 4a46a4a4de

refactor(lib): make new variable local to subshell ae07d242b0

tidy(lib): make snap local to function to avoid name collisions 401c98c3d0

tidy(lib): declare new variable as local for hygiene e633d38d73

tidy(lib): make snap variable local 0679f5d1e0

tidy(lib): make rationale variable local 1620106ec6

tidy(daisy): make out variable local in generate_smell_response call ac6259ff3c

tidy(lib): make out variable local in _loop_smells c342840560

tidy(daisy): Declare now_red as local variable ac66a30969

tidy(lib): limit variable scope to function in generate_tidy_sweep 6376978ff3

refactor(lint-policy): use local variable for rationale 54c2a88758

tidy(daisy): make smell_out variable local to limit scope 39f5f6c8b1

refactor(daisy): make tidy_section local to avoid scope conflicts 425716e776

tidy(lib): declare smell_section as local variable dbf4c17fcc

tidy(lib): make applied local in generate_tidy_sweep 4e9f7f5ec4

tidy(lib): localize tests variable in generate_ripe_response dc0ccdd76d

tidy(lib): make out variable local to function 03207d11b5

tidy(daisy): make ratfile variable local to function 448f8b12a8

tidy(news): scope variables to function in news generation 7bbe06b5c9

tidy(lib-daisy): add local keyword to entry variable declaration 61422d71ec

tidy(daisy): make author variable local to improve scope ef0788968d

tidy(lib): make body local in generate_tidy_response 15f1db641d

tidy(daisy): make entry variable local 8fc09a41af

refactor(daisy): use local variables in generate_mip_response a0ccad5444

calliope commented 2026-06-23 08:26:12 +00:00

Collaborator

Copy link

daktyl review (head be1fbd5)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	8ms	(no bash traps in the diff)
shellcheck	✅ PASS	326ms	(no findings at -S warning)
lint-language	✅ PASS	37ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	140183ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `be1fbd5`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 8ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 326ms | (no findings at -S warning) | | lint-language | ✅ PASS | 37ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 140183ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:26:16 +00:00

erato added 1 commit 2026-06-23 11:37:13 +00:00

fix(daisy): SC2155 — declare then assign ... be1fbd5f2e

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (36 line(s)).

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 12:40:26 +00:00

calliope merged commit e66270b793 into erato/focus 2026-06-23 13:31:52 +00:00

calliope referenced this pull request from a commit 2026-06-23 13:31:54 +00:00

Merge pull request 'cure(daisy): 42 autonomous tidies, skim+companion-gated — for review' (#52) from erato/cure-daisy into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!52

No description provided.