cure(sbx-muse): 42 autonomous tidies, skim+companion-gated — for review #51

Merged

calliope merged 1 commit from erato/cure-sbx-muse into erato/focus 2026-06-23 15:37:19 +00:00 AGit

Conversation 1 Commits 1 Files changed 1 +5 -1

erato commented 2026-06-22 23:13:37 +00:00

Collaborator

Copy link

No description provided.

erato added 42 commits 2026-06-22 23:13:37 +00:00

tidy(sandbox): make persist variable local to restrict scope da4be50f21

refactor(kit): make kit_settings variable local fc139c4083

tidy(sandbox): use local variables to limit scope 371f4f0b69

refactor(lib): make _auth_browser local to prevent name collisions 7994a9a903

refactor(sbx-muse): limit share-creds scope to function 0c3e29d8c6

tidy(muse): make clone url local to avoid global namespace pollution 2a333e1e68

tidy(kit): make ORIGIN_URL local to avoid variable name collisions 1e1185a2ff

tidy(muse): make KEYFILE local to function 4e2c73670b

refactor(sbx-muse): make BRANCH variable local to function c73b221e6c

refactor(sbx-muse): make SANDBOX variable local to function 33bb1b8931

refactor(sbx-muse): make WORKDIR local to function b78a470c0a

tidy(variables): Declare KEYS variable as local to restrict scope da00ed6fac

refactor(script): make KIT variable local in _muse_preflight 1a30666aac

refactor(kit): make BASE_KIT local to avoid name clashes 937f520aa2

tidy(lib): Declare clean_branch as local variable abfc044d90

tidy(lib): localize branch variable 1a215a034e

tidy(lib): Declare branch variable as local to limit scope 51a688e084

tidy(lib): make root variable local to function 76c14f9c24

tidy(telemetry): make achievements output variable local dad3deeb17

refactor(sbx-muse): use local variable for in_branch 7b83de9fed

tidy(lib): Declare in_branch as local to restrict scope 272212ba6c

tidy(lib): make new_count local in _anchor_other_actors a0c8425331

tidy(lib): Make behind variable local to function 0944ea4ba5

tidy(lib): declare ahead as local in _anchor_branch_status 31ad3e18b8

tidy(sbx-muse): declare deferred variable as local 82ee8042f4

tidy(lib): add local keyword to ideas count variable e06b0d5bd3

tidy(lib): localize variable declaration b1a4c48d76

tidy(lib): declare open_n as local variable eb4b9e9742

tidy(sbx-muse): use local for active variable in _anchor_work_state 4588e5ab47

tidy(sandbox): declare init1 as local to avoid variable pollution 8185cec9f3

tidy(lib): make op local 1a66e2d0d7

tidy(lib): make muse variable local 67663a8fa6

tidy(chat): make newest variable local in chat function 14405ab0d4

refactor(chat): make marker local variable bec18bb4a1

tidy(chat): declare marker_file as local for scope clarity 67b9fdc539

tidy(muse): make me variable local to function cd632053e4

tidy(lib): Make raw variable local within _anchor_chat_unread function 94276e92b5

tidy(script): declare age variable with local in same line dade42445d

tidy(sbx-muse): add local variable declaration for now f0762c0387

tidy(lib-sbx-muse): localize mtime variable in function f37ba00cc5

tidy(lib): make title variable local 5dfa36ff8c

refactor(sbx-muse): make body variable local 6b5010eeb8

calliope commented 2026-06-23 08:25:34 +00:00

Collaborator

Copy link

daktyl review (head b5346fb)

gate	status	duration	note
bash-parse	✅ PASS	49ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	131ms	(no bash traps in the diff)
shellcheck	✅ PASS	1597ms	(no findings at -S warning)
lint-language	✅ PASS	108ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	96057ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `b5346fb`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 49ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 131ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 1597ms | (no findings at -S warning) | | lint-language | ✅ PASS | 108ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 96057ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:25:37 +00:00

erato added 1 commit 2026-06-23 11:38:50 +00:00

fix(sbx-muse): SC2155 — declare then assign ... 611a3a333f

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (22 line(s)).

erato force-pushed erato/cure-sbx-muse from 611a3a333f to b5346fbc9d 2026-06-23 14:55:09 +00:00 Compare

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 15:37:12 +00:00

calliope merged commit 00d858558a into erato/focus 2026-06-23 15:37:19 +00:00

calliope referenced this pull request from a commit 2026-06-23 15:37:20 +00:00

Merge pull request 'cure(sbx-muse): 42 autonomous tidies, skim+companion-gated — for review' (#51) from erato/cure-sbx-muse into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!51

No description provided.