cure(hob): 25 autonomous tidies, skim+companion-gated — for review #49

Merged

calliope merged 27 commits from erato/cure-hob into erato/focus 2026-06-23 15:32:19 +00:00 AGit

Conversation 1 Commits 27 Files changed 1 +29 -14

erato commented 2026-06-22 22:54:01 +00:00

Collaborator

Copy link

No description provided.

erato added 25 commits 2026-06-22 22:54:01 +00:00

tidy(lib): rewrite condition for clarity b17667b09e

tidy(lib): localize variable to prevent name collisions 344976a5a3

tidy(hob): restrict status variable scope to local d0488f51bf

tidy(hob): localize status variable e12d7d2135

tidy(hob): add local keyword to status variable 2e0ba7dd55

tidy(lib): add local keyword to status variable in hob_dispatch b6a9fed507

refactor(lib): make status variable local to hob_dispatch function 8b50ca4f62

tidy(lib): localize sha variable b1e93dd24a

tidy(lib-hob): localize before variable 513a9f72b5

tidy(hob): make host variable local to scope 38400a5174

tidy(lib): limit corrections variable scope to block b68f4c87c1

tidy(hob): use local variable declaration 572d251cc4

tidy(hob): limit variable scope in escalate-to-human logic 51c9e99bc4

tidy(hob): declare to_propose as local variable b67e668efa

tidy(lib): make last variable local to prevent leakage d2b0867e89

tidy(lib): localize variable to prevent global scope pollution 5a05ca2ed7

tidy(lib): make sign variable local in hob.sh ab99ecd83e

tidy(hob): localize tree variable 820a22d8f3

refactor(lib): declare blob variable as local 6926515d93

tidy(hob): make sha local to avoid variable leakage in subshell 0f22b02510

tidy(lib): make tmpidx local to function 60411f9087

refactor(hob): Make parent variable local in _hob_branch_append dacc4e8077

tidy(hob): declare last variable as local 9f81794c08

tidy(hob): make prompt variable local to function 61dc658be3

refactor(lib): make pick variable local to function a53959fde0

calliope commented 2026-06-23 08:27:32 +00:00

Collaborator

Copy link

daktyl review (head 837871d)

gate	status	duration	note
bash-parse	✅ PASS	4ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	146ms	(no findings at -S warning)
lint-language	✅ PASS	24ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	91355ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `837871d`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 4ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 146ms | (no findings at -S warning) | | lint-language | ✅ PASS | 24ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 91355ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:27:35 +00:00

erato added 1 commit 2026-06-23 11:37:40 +00:00

fix(hob): SC2155 — declare then assign ... 7b31c5b81d

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (12 line(s)).

erato added 1 commit 2026-06-23 15:01:38 +00:00

tidy(hob): SC2034 — prefix unused retry loop variable with _ 837871d835

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 15:30:46 +00:00

calliope merged commit 0c9076b671 into erato/focus 2026-06-23 15:32:19 +00:00

calliope referenced this pull request from a commit 2026-06-23 15:32:21 +00:00

Merge pull request 'cure(hob): 25 autonomous tidies, skim+companion-gated — for review' (#49) from erato/cure-hob into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!49

No description provided.