cure(findings): 45 autonomous tidies, skim+companion-gated — for review #47

Merged

calliope merged 47 commits from erato/cure-findings into erato/focus 2026-06-23 13:31:45 +00:00 AGit

Conversation 1 Commits 47 Files changed 1 +60 -15

erato commented 2026-06-22 22:38:27 +00:00

Collaborator

Copy link

No description provided.

erato added 45 commits 2026-06-22 22:38:27 +00:00

refactor(findings): split validation conditions for elided lines 35da9ff224

refactor(findings): explicitly handle empty hits case 5a5a92ce2f

refactor(findings): Extract line count regex into variable for clarity 8573989868

refactor(findings): store regex in variable for clarity d9f763a489

refactor(findings): extract regex into variable for readability c4d9bb161a

tidy(findings): add local variable names for improved readability 30ce2ec7f8

refactor(findings): refactor increment logic to use local variable fa270e472f

tidy(findings): name a dense expression for legibility 2f32c7b275

tidy(findings): split condition check into separate line 2b189a270e

refactor(findings): extract and format findings data into variables d689a069d6

refactor(findings): use local variable for body in unfold_naming d761ac8664

tidy(findings): make line variable local in _unfold_naming 0716b6f924

tidy(findings): localize body variable to prevent global pollution 894dd38c80

tidy(lib): make map variable local f205011f46

tidy(lib): make view local to prevent unintended side effects 89a55a588b

tidy(findings): declare body as local to avoid global pollution 3c326026c8

tidy(findings): make rev variable local fa218c8a92

tidy(findings): make cand variable local to prevent side effects 5ab1358981

tidy(findings): localize token variable to avoid global scope pollution 956dd100f0

tidy(findings): make body local 2d4e6b1b5e

tidy(findings): make a local in findings.sh 06df1483f3

tidy(findings): make variables local to improve scope hygiene ebaf5b0499

tidy(findings): declare variables locally to avoid name clashes 6993b7e5f5

tidy(findings): make line variable local to function dd338804aa

tidy(findings): make elided local to avoid side effects 8dc5038f38

tidy(lib): scope variable lc to function scope e9d1c52cf4

tidy(findings): add local keyword to line_match_regex declaration 2a57d71d42

tidy(findings): make variable local in findings.sh aebf9a40f5

tidy(findings): make text variable local to limit scope a009a26ea9

tidy(findings): Use local variable for text in findings_locate 31252e0add

tidy(findings): make text variable local in _findings_locate 7cd8ce05fa

tidy(findings): make text variable local in _findings_locate caa88c5670

tidy(findings): make variable t local to function a01d85155b

tidy(findings): make trimmed_string local to avoid name clashes 0895a62a76

tidy(lib): make variable local to loop in findings function bb417bab07

refactor(findings): declare variable n as local to avoid name clashes c03cee23a8

tidy(findings): make variable local to avoid global pollution f1cced39bb

tidy(findings): localize function name variable to avoid clashes 96ec97970f

tidy(findings): Make variable n local to avoid global scope pollution 3a3b25c788

tidy(findings): localize variable in findings_filter a67f30773f

tidy(findings): make cmsg local to findings_compose ab9e4bf514

refactor(findings): make variables local in findings_compose 78b3fb2d05

refactor(findings): localize variables in findings_compose 6db8ec1a45

tidy(findings): add local to cfile declaration ae3cff22ed

tidy(findings): localize variable to prevent name clashes fe00b497f9

calliope commented 2026-06-23 08:27:49 +00:00

Collaborator

Copy link

daktyl review (head ea7a4bf)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	155ms	(no findings at -S warning)
lint-language	✅ PASS	23ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	90455ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `ea7a4bf`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 155ms | (no findings at -S warning) | | lint-language | ✅ PASS | 23ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 90455ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:27:52 +00:00

erato added 1 commit 2026-06-23 09:35:51 +00:00

fix(findings): drop model preamble, dead block, and over-local cures ... 7609a9df95

The legibility cure had leaked a model chat preamble above the shebang and injected a dead module-scope match_result/BASH_REMATCH block (SC2034/2148/2288/1011). The coupling cure had over-local-ized 9 reassignments into self-shadowing-local hazards. Removed the garbage; dropped the spurious 'local's. skim + shellcheck-no-regression clean, 29 tests green.

erato added 1 commit 2026-06-23 11:37:21 +00:00

fix(findings): SC2155 — declare then assign ... ea7a4bfd80

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (17 line(s)).

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 12:42:06 +00:00

calliope merged commit ce4dc53c68 into erato/focus 2026-06-23 13:31:45 +00:00

calliope referenced this pull request from a commit 2026-06-23 13:31:46 +00:00

Merge pull request 'cure(findings): 45 autonomous tidies, skim+companion-gated — for review' (#47) from erato/cure-findings into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!47

No description provided.