cure(graft): 23 autonomous tidies, skim+companion-gated — for review #46

Merged

calliope merged 24 commits from erato/cure-graft into erato/focus 2026-06-23 13:32:33 +00:00 AGit

Conversation 1 Commits 24 Files changed 1 +25 -5

erato commented 2026-06-22 22:26:43 +00:00

Collaborator

Copy link

No description provided.

erato added 23 commits 2026-06-22 22:26:43 +00:00

tidy(graft): format conditional check as if block 5101cf711b

tidy(lib): localize variable to avoid name clashes b05919d7d4

tidy(graft): limit after variable scope to current function 70091b3dc5

refactor(lib): make snap local to limit scope 64ca2be985

tidy(lib): declare before as local in graft.sh b6b980ba80

refactor(lib): make key variable local to improve scoping 875dbd2e2e

tidy(graft): declare section variable as local 5eee02be2c

tidy(lib): make file variable local in _sweep_stream d3d43a611b

tidy(lib): limit variable scope to current function 4bcf74dfc1

tidy(graft): make got variable local 5c7d2d553b

tidy(grafft): mark want as local in graft script 61fb326c81

refactor(graft): declare variables as local to function e7c431a5c3

tidy(graft): localize variable to restrict scope e22bc34b1b

tidy(graft): make guard variable local 1a9c09a47c

tidy(graft): declare scope as local variable 416a8723e5

tidy(graft): declare src as local to limit scope and avoid side effects 1baf44af6d

tidy(grafft): make variables local to limit scope and prevent clashes 893b840580

tidy(graft): add local variable declaration for fline 35ecbd62c1

tidy(lib): declare variable as local for scope clarity cb557bd2ad

tidy(graft): declare move as local to avoid global scope pollution 53252c1fc5

tidy(graft): use local for variables in _graft_apply function 55eb87807b

tidy(grift): localize prose variable d876028d03

refactor(graft): make timeout local bf77c197bd

calliope commented 2026-06-23 08:28:25 +00:00

Collaborator

Copy link

daktyl review (head b95e568)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	165ms	(no findings at -S warning)
lint-language	✅ PASS	23ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	83851ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `b95e568`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 165ms | (no findings at -S warning) | | lint-language | ✅ PASS | 23ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 83851ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:28:29 +00:00

erato added 1 commit 2026-06-23 11:37:32 +00:00

fix(graft): SC2155 — declare then assign ... b95e56835d

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (18 line(s)).

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 12:42:52 +00:00

calliope merged commit 116ce48d98 into erato/focus 2026-06-23 13:32:33 +00:00

calliope referenced this pull request from a commit 2026-06-23 13:32:34 +00:00

Merge pull request 'cure(graft): 23 autonomous tidies, skim+companion-gated — for review' (#46) from erato/cure-graft into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!46

No description provided.