cure(weave): 22 autonomous tidies, skim+companion-gated — for review #41

Merged

calliope merged 24 commits from erato/cure-weave into erato/focus 2026-06-23 13:31:27 +00:00 AGit

Conversation 1 Commits 24 Files changed 1 +35 -11

erato commented 2026-06-22 22:15:56 +00:00

Collaborator

Copy link

No description provided.

erato added 22 commits 2026-06-22 22:15:56 +00:00

refactor(weave): refactor condition checks into separate variables 8f65e6d246

refactor(weave): split regex pattern into components for clarity a5f0e3a81f

tidy(weave): make content variable local to prevent scope pollution 435cf10bd7

tidy(weave): localize body variable in weave_run function ce0ca2ba1f

tidy(weave): add local scope to variable declaration 9eba9f690a

tidy(weave): make out variable local to avoid scope pollution 4e57df21eb

tidy(weave): make test variable local in loop db3438a98f

tidy(weave): make tmp variable local to function a1446eb0f3

tidy(weave): make variables local to improve scope 4598e6ed69

refactor(weave): scope variable 'prev' to local 0b2f34b8fd

tidy(lib): make b_condition local to avoid name collisions 109c2d45eb

tidy(weave): localize a_condition variable in weave_expand function 1c62912e17

tidy(lib): make prev_condition local to avoid global pollution ebd4c78909

tidy(lib): make b_condition local to improve scope isolation 1c81821441

tidy(lib): make a_condition local in weave_expand 9fe00ae9bd

tidy(lib): make prev_condition local to function scope 23f75f3a31

tidy(weave): make variables local to avoid global scope pollution e366fa8690

tidy(weave): make line local to avoid side effects 61833548e0

tidy(lib): limit variable scope to function 4b02d7959f

tidy(lib): localize variable in weave parse function d7b03702fe

tidy(weave): localize cre variable ed56538047

tidy(weave): make variables local to enforce scope isolation e448c10c9a

calliope commented 2026-06-23 08:32:11 +00:00

Collaborator

Copy link

daktyl review (head 78715c7)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	75ms	(no findings at -S warning)
lint-language	✅ PASS	20ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	91054ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `78715c7`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 75ms | (no findings at -S warning) | | lint-language | ✅ PASS | 20ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 91054ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:32:14 +00:00

erato added 1 commit 2026-06-23 09:35:56 +00:00

fix(weave): brace regex-part vars; $name[ read as indexing (SC1087) 0994676ae0

erato added 1 commit 2026-06-23 11:39:51 +00:00

fix(weave): SC2155 — declare then assign ... 78715c791d

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (5 line(s)).

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 12:45:48 +00:00

calliope merged commit 5342f9389b into erato/focus 2026-06-23 13:31:27 +00:00

calliope referenced this pull request from a commit 2026-06-23 13:31:28 +00:00

Merge pull request 'cure(weave): 22 autonomous tidies, skim+companion-gated — for review' (#41) from erato/cure-weave into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!41

No description provided.