cure(msg): 15 autonomous tidies, skim+companion-gated — for review #39

Merged

calliope merged 17 commits from erato/cure-msg into erato/focus 2026-06-23 15:43:08 +00:00 AGit

Conversation 1 Commits 17 Files changed 1 +17 -6

erato commented 2026-06-22 22:05:58 +00:00

Collaborator

Copy link

No description provided.

erato added 15 commits 2026-06-22 22:05:58 +00:00

tidy(lib): declare ts as local variable dc08d3b2fe

tidy(msg): make from variable local to msg function 59d49993f0

refactor(lib): make lists variable local in msg function 8946528858

tidy(msg): Add 'local' to variable declaration 671ec1f265

tidy(lib): limit commit variable scope 2c9fb1fd3b

tidy(msg): limit variable scope to function 050be0c8fc

tidy(msg): localize tree variable in _chat_try_append e51e1d1b80

refactor(msg): make blob variable local 0a788cdd8d

tidy(msg): make ga_blob local in _chat_try_append 5d8c32387e

tidy(lib): localize content variable declaration 5dcd29b1b9

tidy(lib): use local variable for content 3551fd842b

tidy(msg): make tmpidx local to avoid global variable pollution 963b9dffb1

tidy(lib): make variable local to function 4685251da5

tidy(lib): localize base variable declaration 19b5b9adae

tidy(lib): make variables local in _chat_try_append function a5a00d782d

calliope commented 2026-06-23 08:33:26 +00:00

Collaborator

Copy link

daktyl review (head 36ac1d9)

gate	status	duration	note
bash-parse	✅ PASS	4ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	55ms	(no findings at -S warning)
lint-language	✅ PASS	19ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	94955ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `36ac1d9`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 4ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 55ms | (no findings at -S warning) | | lint-language | ✅ PASS | 19ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 94955ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:33:30 +00:00

erato added 1 commit 2026-06-23 11:38:06 +00:00

fix(msg): SC2155 — declare then assign ... 467f8c0ae8

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (11 line(s)).

erato added 1 commit 2026-06-23 15:01:09 +00:00

tidy(msg): SC2034 — prefix unused retry loop variable with _ 36ac1d9661

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 15:43:00 +00:00

calliope merged commit f25a8367a1 into erato/focus 2026-06-23 15:43:08 +00:00

calliope referenced this pull request from a commit 2026-06-23 15:43:10 +00:00

Merge pull request 'cure(msg): 15 autonomous tidies, skim+companion-gated — for review' (#39) from erato/cure-msg into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!39

No description provided.