cure(achievements): 10 autonomous tidies, skim+companion-gated — for review #36

Merged

calliope merged 11 commits from erato/cure-achievements into erato/focus 2026-06-23 13:26:21 +00:00 AGit

Conversation 1 Commits 11 Files changed 1 +10 -3

erato commented 2026-06-22 22:01:43 +00:00

Collaborator

Copy link

No description provided.

erato added 10 commits 2026-06-22 22:01:43 +00:00

tidy(achievements): make entries variable local to restrict scope bafcd1cbf0

tidy(achievements): make type local in achievements_scan d21513d3fc

refactor(achievements): Make range variable local in achievements_scan 0ed99b4b32

tidy(achievements): Limit range variable scope a77a17b645

tidy(achievements): restrict variable scope in tag processing 75aa6fc5c0

tidy(achievements): declare kind as local variable 0c4a554450

tidy(achievements): Declare last_sha as local to restrict scope 12d6fc6bcc

tidy(achievements): Declare seen_tags as local variable 281a704476

tidy(achievements): declare cur_sha as local to improve variable scoping f4a1a4e9de

tidy(achievements): make current_tags local to avoid name collisions eb18dbd806

calliope commented 2026-06-23 08:35:02 +00:00

Collaborator

Copy link

daktyl review (head a350e92)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	8ms	(no bash traps in the diff)
shellcheck	✅ PASS	55ms	(no findings at -S warning)
lint-language	✅ PASS	17ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	85252ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `a350e92`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 8ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 55ms | (no findings at -S warning) | | lint-language | ✅ PASS | 17ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 85252ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:35:06 +00:00

erato added 1 commit 2026-06-23 11:36:32 +00:00

fix(achievements): SC2155 — declare then assign ... a350e92c36

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (7 line(s)).

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 12:48:37 +00:00

calliope merged commit 1df6953576 into erato/focus 2026-06-23 13:26:21 +00:00

calliope referenced this pull request from a commit 2026-06-23 13:26:23 +00:00

Merge pull request 'cure(achievements): 10 autonomous tidies, skim+companion-gated — for review' (#36) from erato/cure-achievements into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!36

No description provided.