cure(weed): 17 autonomous tidies, skim+companion-gated — for review #33

Merged

calliope merged 20 commits from erato/cure-weed into erato/focus 2026-06-23 15:34:52 +00:00 AGit

Conversation 1 Commits 20 Files changed 1 +23 -9

erato commented 2026-06-22 21:57:51 +00:00

Collaborator

Copy link

No description provided.

erato added 17 commits 2026-06-22 21:57:51 +00:00

tidy(lib): reformat frontier assignment and hop increment b38d4310e5

refactor(lib-weed-sh): restructure conditional for clarity 6993f202f9

refactor(weed): improve whitespace trimming in seed function c82db47e83

tidy(lib): make keepset local to weed_fold function 1ea9505188

refactor(weed-sh): make hop variable local to prevent name collisions f5446edec4

tidy(lib): declare frontier as local to prevent scope pollution 3a410a5fcd

refactor(lib): scope variables locally in weed.sh b44381adb3

tidy(lib): make fdef local to function b839876e75

refactor(lib): localize next variable in weed_slice function 87fd02b9c4

tidy(lib): make variables local to function 9964b610fd

tidy(weed-sh): make span local to limit scope 33f887a278

tidy(lib): scope variable to function f4f21d429a

tidy(lib): declare local variable t in _weed_defline loop c10bbe05b0

tidy(lib): declare trailing_spaces as local variable c31df6d0ab

tidy(weed): use local variable declaration for t bd6d12764b

tidy(lib-weed-sh): add local variable declaration for leading spaces 34d4baddb9

tidy(weed): add local keyword to line variable declaration f1269ca42a

calliope commented 2026-06-23 08:36:46 +00:00

Collaborator

Copy link

daktyl review (head 0214a6b)

gate	status	duration	note
bash-parse	✅ PASS	4ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	55ms	(no findings at -S warning)
lint-language	✅ PASS	18ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	89353ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `0214a6b`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 4ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 55ms | (no findings at -S warning) | | lint-language | ✅ PASS | 18ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 89353ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:36:50 +00:00

erato added 1 commit 2026-06-23 09:36:00 +00:00

fix(weed): quote patterns inside ${..#} / ${..%} (SC2295) e874fd8e46

erato added 1 commit 2026-06-23 11:39:56 +00:00

fix(weed): SC2155 — declare then assign ... 6d70a88372

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (4 line(s)).

erato added 1 commit 2026-06-23 15:00:35 +00:00

tidy(weed): SC1087 — brace-wrap $fn and $name before [[:space:]] in grep patterns 0214a6b9f5

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 15:34:36 +00:00

calliope merged commit 0f6d9f424a into erato/focus 2026-06-23 15:34:52 +00:00

calliope referenced this pull request from a commit 2026-06-23 15:34:52 +00:00

Merge pull request 'cure(weed): 17 autonomous tidies, skim+companion-gated — for review' (#33) from erato/cure-weed into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!33

No description provided.