cure(behold-bash-trellis): 9 autonomous tidies, skim+companion-gated — for review #32

Merged

calliope merged 11 commits from erato/cure-behold-bash-trellis into erato/focus 2026-06-23 15:32:01 +00:00 AGit

Conversation 1 Commits 11 Files changed 1 +10 -1

erato commented 2026-06-22 21:55:19 +00:00

Collaborator

Copy link

No description provided.

erato added 9 commits 2026-06-22 21:55:19 +00:00

refactor(bash-trellis): enforce variable scope to prevent pollution 9f9105b5ce

refactor(script): make failure_line_json local to function 2459f3b8be

tidy(bash-trellis): limit variable scope to function 6c78cb2576

tidy(bash-trellis): Make slow_names local to function 77b38704da

tidy(behold-bash-trellis): make stale_names local to function 713f5bc5dc

tidy(behold-bash-trellis): make variables local d868afb06f

tidy(bash-trellis): Declare variables as local to limit scope 9ffa7d6ca5

refactor(bash-trellis): declare trellis_output as local variable d4a7063802

tidy(bash-trellis): add local keyword to test_names declaration fd1950a8cf

calliope commented 2026-06-23 08:37:57 +00:00

Collaborator

Copy link

daktyl review (head c398938)

gate	status	duration	note
bash-parse	✅ PASS	5ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	✅ PASS	35ms	(no findings at -S warning)
lint-language	✅ PASS	18ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	80348ms	(full suite green)

Verdict: 5/5 gates green. ✅ Awaiting judgment.

## daktyl review (head `c398938`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 5ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ✅ PASS | 35ms | (no findings at -S warning) | | lint-language | ✅ PASS | 18ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 80348ms | (full suite green) | **Verdict:** 5/5 gates green. ✅ Awaiting judgment.

calliope added the

gates-red

label 2026-06-23 08:38:00 +00:00

erato added 1 commit 2026-06-23 11:36:51 +00:00

fix(behold-bash-trellis): SC2155 — declare then assign ... 3d4937d7c7

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (9 line(s)).

erato added 1 commit 2026-06-23 14:59:49 +00:00

tidy(behold-bash-trellis): SC2034 — prefix unused source_file param with _ c398938380

calliope added

awaiting-judgment

gates-green

and removed

gates-red

labels 2026-06-23 15:27:24 +00:00

calliope merged commit e2dca33b6a into erato/focus 2026-06-23 15:32:01 +00:00

calliope referenced this pull request from a commit 2026-06-23 15:32:03 +00:00

Merge pull request 'cure(behold-bash-trellis): 9 autonomous tidies, skim+companion-gated — for review' (#32) from erato/cure-behold-bash-trellis into erato/focus

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!32

No description provided.