cure(prick-out): 6 autonomous tidies, skim+companion-gated — for review #24

Closed

erato wants to merge 0 commits from erato/cure-prick-out into erato/focus AGit

pull from: erato/cure-prick-out

merge into: fqqdk:erato/focus

fqqdk:focus

fqqdk:clio/test-health-role

fqqdk:clio/focus

fqqdk:erato/focus

fqqdk:euterpe/focus

fqqdk:thalia/focus

fqqdk:clio/fidelity-axis

fqqdk:calliope/focus

fqqdk:conversation

fqqdk:clio/close-euterpe

fqqdk:clio/go-pending

fqqdk:clio/go-pipeline-blocked

fqqdk:clio/js-tests

fqqdk:clio/js-exceptions

fqqdk:clio/js-oo-fixtures

fqqdk:clio/js-oo

fqqdk:clio/selective-unblock

fqqdk:clio/language-blocked

fqqdk:clio/type-inference

fqqdk:clio/night/oo-grind

fqqdk:clio/night/more-refactors

fqqdk:clio/query-param

fqqdk:clio/unblocked

fqqdk:clio/params

fqqdk:clio/night/ready-refactors

fqqdk:clio/night/legibility-axis

fqqdk:thalia/slim-cure-consolidation

fqqdk:ts-refactors

fqqdk:ts-cures-slim

fqqdk:encapsulate-atoms

fqqdk:erato/refactors

fqqdk:calliope/refactors

fqqdk:thalia/ts-refactors

fqqdk:mend-loop

fqqdk:euterpe/sql-plugin

fqqdk:thalia/hyperdoc-typescript

fqqdk:clio/hyperdoc-metrics

fqqdk:calliope/night/catalog-ports

fqqdk:clio/daisy-php

fqqdk:calliope/hyperdoc

fqqdk:calliope/night/daisy-rs

fqqdk:calliope/trim-tests

fqqdk:calliope/externalise-apply

fqqdk:clio/opus-run

fqqdk:calliope/mechanical-cures

fqqdk:clio/fix-extensions

fqqdk:calliope/perl-catalog

fqqdk:clio/night/gate-fixes

fqqdk:calliope/night/cpp-catalog

fqqdk:clio/node-cure-experiment

fqqdk:polyhymnia/focus

fqqdk:calliope/daktyl-review

fqqdk:calliope/lint-bash-traps-allow

fqqdk:erato/cure-feedback-retry

fqqdk:calliope/xeny-frontend-vm-rig

fqqdk:erato/cure-mechanism-fix

fqqdk:erato/no-build-verb

fqqdk:erato/speak-verb

fqqdk:erato/skim-gate

fqqdk:erato/green-gate-findings

fqqdk:erato/spiral-green-gate

fqqdk:erato/mend-bash-cleanup

fqqdk:erato/mend-loop

fqqdk:erato/mend-strangler-fig

fqqdk:erato/mend-recharacterization-gate

fqqdk:erato/mend-verb

fqqdk:polyhymnia/thinking-stream

fqqdk:erato/cross-file-breakage

fqqdk:erato/scale-run-findings

fqqdk:polyhymnia/chain-preamble

fqqdk:erato/logistic-findings

fqqdk:erato/logistic-walk

fqqdk:erato/correct-take-trigger

fqqdk:erato/plan-the-residue

fqqdk:erato/structural-take

fqqdk:erato/escalate-on-starve

fqqdk:erato/starved-asks-for-help

fqqdk:erato/convergence-ladder

fqqdk:erato/drive-loop-to-fixpoint

fqqdk:erato/convergence-experiment

fqqdk:erato/convergence-fleet-run

fqqdk:erato/convergence-corpus

fqqdk:erato/converge-probe

fqqdk:erato/settled-or-starved

fqqdk:erato/phi-emit

fqqdk:clio/ide-legible-sandbox

fqqdk:calliope/legible-workspace

fqqdk:calliope/route

fqqdk:thalia/portable-box

fqqdk:calliope/portable-box

fqqdk:calliope/realtime-gates

fqqdk:calliope/forge-identity

fqqdk:clio-sbx

Conversation 1 Commits - Files changed -

erato commented 2026-06-22 21:37:30 +00:00

Collaborator

Copy link

No description provided.

erato added 6 commits 2026-06-22 21:37:30 +00:00

tidy(lib): declare rebuilt as local variable b0787acffa

tidy(lib-prick-out): declare 'got' as local variable 03a0ba047b

tidy(prick-out): make want and got local variables f1418ee96c

tidy(prick-out): localize edited variable 8b08b2b626

refactor(lib): Make lang local 9fee161aae

tidy(lib): Declare timeout variable locally with assignment 717f4c4a53

calliope commented 2026-06-23 08:42:15 +00:00

Collaborator

Copy link

daktyl review (head 717f4c4)

gate	status	duration	note
bash-parse	✅ PASS	4ms	(no changed .sh failed parse)
lint-bash-traps	✅ PASS	7ms	(no bash traps in the diff)
shellcheck	❌ FAIL	35ms	1 file(s) with findings — see .daktyl/shellcheck.log
lint-language	✅ PASS	17ms	(no vocabulary violations in diff)
daisy-validate	✅ PASS	114968ms	(full suite green)

Verdict: 4/5 gates green. ❌ Send back for rework.

## daktyl review (head `717f4c4`) | gate | status | duration | note | |---|---|---|---| | bash-parse | ✅ PASS | 4ms | (no changed .sh failed parse) | | lint-bash-traps | ✅ PASS | 7ms | (no bash traps in the diff) | | shellcheck | ❌ FAIL | 35ms | 1 file(s) with findings — see .daktyl/shellcheck.log | | lint-language | ✅ PASS | 17ms | (no vocabulary violations in diff) | | daisy-validate | ✅ PASS | 114968ms | (full suite green) | **Verdict:** 4/5 gates green. ❌ Send back for rework.

calliope added the

gates-red

label 2026-06-23 08:42:19 +00:00

erato added 1 commit 2026-06-23 11:38:31 +00:00

fix(prick-out): SC2155 — declare then assign ... 59330ed1fe

Split the coupling cure's introduced 'local x=$(cmd)' into 'local x' / 'x=$(cmd)' so the command's return is not masked — the two-line form the reviewer's shellcheck expects (6 line(s)).

erato force-pushed erato/cure-prick-out from 59330ed1fe to 376b057074 2026-06-23 11:41:52 +00:00 Compare

calliope closed this pull request 2026-06-23 15:21:55 +00:00

All checks were successful

Hide all checks

test / suite (push) Successful in 2m0s

Details

test / suite (pull_request) Successful in 2m7s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

awaiting-judgment

  

gates-green

  

gates-red

No labels

awaiting-judgment

gates-green

gates-red

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

fqqdk/daisy!24

No description provided.